Recent posts

#1
General Discussion / The Rising Importance of Guest...
Last post by Edwindor - Today at 02:45:25 AM
can assist determine key terms that truly accelerate sales
#2
User Interface / Re: Indigo UI: the properties ...
Last post by tim_occ - November 28, 2023, 11:28:01 PM
Just another update. All new big UI changes are documented in the Wiki.

https://wiki.scribus.net/canvas/IndigoDevelopment
#3
Code / Re: Scribus scripting function...
Last post by Darkoni - November 27, 2023, 09:55:33 PM

I have made a merge request:

https://gitlab.com/scribus/scribus/-/merge_requests/46

Looking forward to discuss and see the changes.

Best regards,
Darko Nikolić
#4
Code / Re: Scribus scripting function...
Last post by MrB - November 27, 2023, 09:47:11 PM
I'm happy to review all of these changes, potentially all for 1.7.0 codebase, and some, maybe all for 1.6.1. We're waiting on one last thing to release 1.6.0 which is the French UI translation. Once that's done by Jean, we'll release it. After that, we can look at all of this stuff. Thank you for reviewing those scripter functions.
#5
Code / Re: Scribus scripting function...
Last post by Darkoni - November 27, 2023, 09:36:41 PM
MrB

You are right. I will format special chars to HTML tags: < > &

Thanks for pointing out.

I find there are other 'strings', namely:

PAPER_<paper_type>
UNIT_<type>
FILL_<type>
CAP_<type>
JOIN_<type>
LINE_<style>
<selection>
0 <= state <= 3
<i></i>

Note that only <style> causes trouble.

I will leave point 11. as it is.

But, what about the other points on this forum thread?

Regards
#6
Code / Re: Scribus scripting function...
Last post by MrB - November 27, 2023, 08:58:21 PM
As Ale points out, this is a problem with the website conversion code, should should set to &lt; or &gt;, not Scribus code.
#7
Code / Re: Scribus scripting function...
Last post by Darkoni - November 27, 2023, 12:37:16 PM


Can we continue as I have prepared Scribus fork:

https://gitlab.com/Darkoni/darkoni-scribus/-/tree/docstrings

#8
Code / Re: Scribus scripting function...
Last post by a.l.e - November 26, 2023, 08:57:03 PM
concerning the < style > ... i guess that i will have to tweak my script to convert it to &lt; style &gt; .

theoretically, < and > can be the start and html tags and should be escaped... but since they mostly work i normally don't do it.
#9
Code / Re: Scribus scripting function...
Last post by a.l.e - November 26, 2023, 08:50:29 PM
fixing the docstrings is for sure a good thing. but i find it hard to follow the all the changes you're suggesting.

since you're already using gitlab, would you mind creating a new branch with the changes, create a merge request and adding the link in here?

then we can start a review on gitlab with inline comments attached to the specific lines of code.

sadly it's not (yet) possible to accept merge requests, but if you're as lazy as i am, you can add a .diff to the url and create a diff that you can download and use for uploading to the scribus bug tracker : - )
#10
Code / Re: Scribus scripting function...
Last post by Darkoni - November 26, 2023, 08:49:18 PM
And there is another feature in Scribus code:

### 11. LINE_< style >

File: scribus/plugins/scriptplugin/cmdsetprop.h

/*! docstring */
PyDoc_STRVAR(scribus_setlinestyle__doc__,
QT_TR_NOOP("setLineStyle(style, [\"name\"])\n\
\n\
Sets the line style of the object \"name\" to the style \"style\". If \"name\"\n\
is not given the currently selected item is used.\n\
Argument for this function is number - value from 1 to 37\n\
There are few predefined constants for \"style\" - LINE_< style >.\n\
In Property Palette this feature is selected in box named 'Type of line'\n\
"));
/*! Set line end */
PyObject *scribus_setlinestyle(PyObject * /*self*/, PyObject* args);

Why is this important?

There is a nice site Scribus Scripter API

https://impagina.org/scribus-scripter-api/

"This API documentation has been generated from Scribus 1.7.0.svn (2023-11-18)."

And on one of the pages there is missing content.

https://impagina.org/scribus-scripter-api/other-style/

Missing documentation for setTableStyle and also page footer is missing.

All because of HTML tag style in Scribus code.

All becouse of text LINE_< style > in code.

Could Scribus dev team fix this minor thing?

Thanks!

Darko Nikolić